Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12552] Session Copy Modal: Instructors able to select the Course that they are copying from #13149

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Respirayson
Copy link
Contributor

@Respirayson Respirayson commented Jul 19, 2024

Fixes #12552

Outline of Solution
To fix this issue, whenever the instructor selects the same course that the feedback session belongs to, there'll be an alert that pops up to say that there already exists a session with the same name in that course.

TEAMMATES.-.Online.Peer.Feedback_Evaluation.System.for.Student.Team.Projects.-.Google.Chrome.2024-08-03.14-53-40.mp4

image

image

@Respirayson Respirayson marked this pull request as draft July 19, 2024 19:12
@Respirayson Respirayson marked this pull request as ready for review July 19, 2024 19:24
@domoberzin
Copy link
Contributor

I think standardizing the copies to have 'Copy of' prepended by default is okay, since the instructor would be able to edit this name in the modal, but @damithc would you like to weigh in on this change?

@mingyuanc
Copy link
Contributor

@damithc Prof any updates?

@damithc
Copy link
Contributor

damithc commented Jul 30, 2024

Hmm... Google docs allows the user to change the session name later, but we don't allow users to change the session name later. So, this strategy can lead to more severe problems than the current issue which is a mere inconvenience. For example, the user might not realize the name was prepended with a 'Copy of' until much later, when it is too late to even delete it.
So, I prefer to keep the same session name unless the user changes it but prompt the user to change it when we detect a likely name collision e.g., if the name and course is same as the original, show a red warning message somewhere in the copy dialog. Is that feasible?

@domoberzin
Copy link
Contributor

@damithc thanks for the input Prof, I think that's a fair approach to take for this

@Respirayson could you implement it as described above? So there shouldn't be a 'Copy of' prepended but rather a warning/error within the popup when the name and course are the same

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 13 days). 🐌 😢
Hope someone can get it to move forward again soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session Copy Modal: Instructors able to select the Course that they are copying from
5 participants